Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing plugins on time for using xcube-gen-.. #67

Merged
merged 1 commit into from
May 10, 2019

Conversation

AliceBalfanz
Copy link
Contributor

This PR fixes issue #66.
Before the only time plugins were loaded was when executing 'xcube.cli', but for xcube-gen-... it is also needed within 'xcube.api.gen.gen' in order not to receive an import error.

…oad plugins in time for xcube gen input processor plugins. This fixes issue #66
@AliceBalfanz AliceBalfanz requested a review from forman May 10, 2019 11:11
@codecov-io
Copy link

codecov-io commented May 10, 2019

Codecov Report

Merging #67 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #67      +/-   ##
=========================================
+ Coverage    84.6%   84.6%   +<.01%     
=========================================
  Files          70      70              
  Lines        5975    5976       +1     
=========================================
+ Hits         5055    5056       +1     
  Misses        920     920
Impacted Files Coverage Δ
xcube/api/gen/gen.py 82.19% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bbec0...f71f806. Read the comment docs.

Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@forman forman merged commit 98d1878 into master May 10, 2019
@AliceBalfanz AliceBalfanz deleted the alicja-66-import-plugins branch May 17, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants